yamllint + ansible-lint

.travis.yml

@@ -8,7 +8,7 @@ env:
   - distro: debian9
   - distro: debian8
   - distro: alpine
-  #- distro: archlinux
+  # - distro: archlinux
 
 script:
   # Configure test script so we can run extra tests after playbook is run

defaults/main.yml

@@ -9,7 +9,7 @@ msmtp_accounts:
       from: emailer-tests@yandex.com
       user: emailer-tests@yandex.com
       password: jhlrizltgkmnkkgm
-      #Account 2
+    # Account 2
     - account: mysmtp
       host: smtp.example
       port: 587
@@ -17,7 +17,7 @@ msmtp_accounts:
       from: admin@example.org
       user: myuser@example.org
       password: plain-text-password2
-      #Account 3
+    # Account 3
     - account: gmail
       host: smtp.gmail.com
       port: 587

meta/main.yml

@@ -1,3 +1,4 @@
+---
 galaxy_info:
   author: Adham Helal, Christian Wagner, gitouche
   description: "Deploy msmtp mailer on RHEL8"

tasks/main.yml

@@ -1,20 +1,16 @@
 ---
-# Deploy msmtp
-
-# TODO:
-# Fix: Check if mailserver is ready, as Test mail will only work,
-# if msmtp is setup after the mailserver is already configured
-
 - name: Copy RPM file to server
   copy:
     src: msmtp-1.8.15-1.el8.x86_64.rpm
     dest: /tmp/msmtp-1.8.15-1.el8.x86_64.rpm
+    mode: 0400
   when: ansible_os_family == "RedHat"
 
 - name: Copy systemd unit file to server
   copy:
     src: msmtpd.service
     dest: /etc/systemd/system/msmtpd.service
+    mode: 0400
   when: ansible_os_family == "RedHat"
 
 - name: enable daemon
@@ -71,6 +67,7 @@
   template:
     src: sysconfig.j2
     dest: /etc/sysconfig/msmtpd
+    mode: 0444
   notify:
     - test mail
     - restart msmtpd