yamllint + ansible-lint

.travis.yml

@@ -8,7 +8,7 @@ env:
   - distro: debian9
   - distro: debian8
   - distro: alpine
-  #- distro: archlinux
+  # - distro: archlinux
 
 script:
   # Configure test script so we can run extra tests after playbook is run

defaults/main.yml

@@ -2,44 +2,44 @@
 msmtp_accounts:
     # Account 1 - it was a real account for testing (but yandex now blocks it)
     # Uses Yandex app password limited to POP3, SMTP and IMAP
-    - account:   yandex
+    - account: yandex
-      host:      smtp.yandex.com
+      host: smtp.yandex.com
-      port:      587
+      port: 587
-      auth:      "on"
+      auth: "on"
-      from:      emailer-tests@yandex.com
+      from: emailer-tests@yandex.com
-      user:      emailer-tests@yandex.com
+      user: emailer-tests@yandex.com
-      password:  jhlrizltgkmnkkgm
+      password: jhlrizltgkmnkkgm
-      #Account 2
+    # Account 2
-    - account:   mysmtp
+    - account: mysmtp
-      host:      smtp.example
+      host: smtp.example
-      port:      587
+      port: 587
-      auth:      "on"
+      auth: "on"
-      from:      admin@example.org
+      from: admin@example.org
-      user:      myuser@example.org
+      user: myuser@example.org
-      password:  plain-text-password2
+      password: plain-text-password2
-      #Account 3
+    # Account 3
-    - account:   gmail
+    - account: gmail
-      host:      smtp.gmail.com
+      host: smtp.gmail.com
-      port:      587
+      port: 587
-      auth:      "on"
+      auth: "on"
-      from:      example@gmail.example
+      from: example@gmail.example
-      user:      example@gmail.example
+      user: example@gmail.example
-      password:  "some password"
+      password: "some password"
 
 msmtp_default_account: yandex
-msmtp_domain:          yandex.com
+msmtp_domain: yandex.com
 
 ## Enable or disable automatic envelope-from addresses
 msmtp_auto_from: 'off'
 
 ## Logging (Select A) "syslog" or B) "file" logging or C) "no" log
-msmtp_log:       file
+msmtp_log: file
-msmtp_logfile:   ~/.msmtp.log
+msmtp_logfile: ~/.msmtp.log
 
 ## Aliases mail account ( only msmtp_alias_default is required the rest is optional )
 msmtp_alias_default: emailer.tests@yandex.com
-msmtp_alias_root:    emailer.tests@yandex.com
+msmtp_alias_root: emailer.tests@yandex.com
-msmtp_alias_cron:    emailer.tests@yandex.com
+msmtp_alias_cron: emailer.tests@yandex.com
 
 ## Enable, after the the default smtp account is working
 msmtp_send_test_mail: no

meta/main.yml

@@ -1,13 +1,14 @@
+---
 galaxy_info:
   author: Adham Helal, Christian Wagner, gitouche
   description: "Deploy msmtp mailer on RHEL8"
   min_ansible_version: 2.4
   license: Apache
   platforms:
-  - name: EL
+    - name: EL
-    versions:
+      versions:
-    - 8
+        - 8
   tags:
-  - mail
+    - mail
-  - system
+    - system
-  - networking
+    - networking

tasks/main.yml

@@ -1,20 +1,16 @@
 ---
-# Deploy msmtp
-
-# TODO:
-# Fix: Check if mailserver is ready, as Test mail will only work,
-# if msmtp is setup after the mailserver is already configured
-
 - name: Copy RPM file to server
   copy:
     src: msmtp-1.8.15-1.el8.x86_64.rpm
     dest: /tmp/msmtp-1.8.15-1.el8.x86_64.rpm
+    mode: 0400
   when: ansible_os_family == "RedHat"
 
 - name: Copy systemd unit file to server
   copy:
     src: msmtpd.service
     dest: /etc/systemd/system/msmtpd.service
+    mode: 0400
   when: ansible_os_family == "RedHat"
 
 - name: enable daemon
@@ -44,11 +40,11 @@
 
 - name: Copy mstprc conf file.
   template:
-     src: msmtprc.j2
+    src: msmtprc.j2
-     dest: /etc/msmtprc
+    dest: /etc/msmtprc
-     owner: root
+    owner: root
-     group: msmtp
+    group: msmtp
-     mode: 0640
+    mode: 0640
   tags: mail
   notify:
     - test mail
@@ -71,6 +67,7 @@
   template:
     src: sysconfig.j2
     dest: /etc/sysconfig/msmtpd
+    mode: 0444
   notify:
     - test mail
     - restart msmtpd